-
Notifications
You must be signed in to change notification settings - Fork 797
[CI][Benchmarks] Refactor Compute Runtime builds #19303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: If the only thing that changes is Compute Runtime, we don't have to rebuild all of dependencies. Perhaps there are some other situations that could limit the harsh clean rebuild criteria. |
845bb14
to
5c3127a
Compare
5c3127a
to
010de94
Compare
d1a5918
to
1953df4
Compare
Rebased, ready for review |
igchor
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
df36dc5
to
cabcda7
Compare
- don't rebuild any of the Compute Runtime components if none of them has changed - rebuild Compute Runtime and its components if needed - refactor components directories' names to be more consistent - overall refactor the compute_runtime module - make Suite.setup() an abstract method
@intel/llvm-gatekeepers, please merge |
dm-vodopyanov
pushed a commit
that referenced
this pull request
Jul 23, 2025
Recent refactor of compute-runtime utils, #19303, introduced a regression that caused IGC dependencies to be fetched into incorrect directories, causing build failures. This patch fixes the directory path for IGC directories, allowing the recent compute-runtime drivers to be built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #19158Please, review only the last commit