Skip to content

[CI][Benchmarks] Refactor Compute Runtime builds #19303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Jul 4, 2025

  • don't rebuild any of the Compute Runtime components if none of them has changed
  • rebuild Compute Runtime and all of its components if any of them has changed
  • refactor components directories' names to be more consistent

Requires: #19158
Please, review only the last commit

@PatKamin PatKamin temporarily deployed to WindowsCILock July 4, 2025 12:07 — with GitHub Actions Inactive
@PatKamin
Copy link
Contributor Author

PatKamin commented Jul 4, 2025

TODO: If the only thing that changes is Compute Runtime, we don't have to rebuild all of dependencies.

Perhaps there are some other situations that could limit the harsh clean rebuild criteria.

@PatKamin PatKamin temporarily deployed to WindowsCILock July 4, 2025 12:30 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 4, 2025 12:30 — with GitHub Actions Inactive
@PatKamin PatKamin force-pushed the compute-runtime-build branch 2 times, most recently from 845bb14 to 5c3127a Compare July 8, 2025 13:17
@PatKamin PatKamin temporarily deployed to WindowsCILock July 8, 2025 13:17 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 8, 2025 13:52 — with GitHub Actions Inactive
@PatKamin PatKamin force-pushed the compute-runtime-build branch from 5c3127a to 010de94 Compare July 8, 2025 14:27
@PatKamin PatKamin temporarily deployed to WindowsCILock July 8, 2025 14:27 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 8, 2025 15:00 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 8, 2025 15:00 — with GitHub Actions Inactive
@PatKamin PatKamin force-pushed the compute-runtime-build branch 2 times, most recently from d1a5918 to 1953df4 Compare July 10, 2025 12:59
@PatKamin PatKamin marked this pull request as ready for review July 10, 2025 12:59
@PatKamin PatKamin requested a review from a team as a code owner July 10, 2025 12:59
@PatKamin
Copy link
Contributor Author

Rebased, ready for review

@PatKamin PatKamin marked this pull request as draft July 11, 2025 09:53
Copy link
Member

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatKamin PatKamin force-pushed the compute-runtime-build branch from df36dc5 to cabcda7 Compare July 17, 2025 12:23
@PatKamin PatKamin marked this pull request as ready for review July 17, 2025 12:24
- don't rebuild any of the Compute Runtime components if none of them
has changed
- rebuild Compute Runtime and its components if needed
- refactor components directories' names to be more consistent
- overall refactor the compute_runtime module
- make Suite.setup() an abstract method
@PatKamin
Copy link
Contributor Author

@intel/llvm-gatekeepers, please merge

@uditagarwal97 uditagarwal97 merged commit ff512f5 into intel:sycl Jul 21, 2025
38 of 39 checks passed
@PatKamin PatKamin deleted the compute-runtime-build branch July 22, 2025 13:50
dm-vodopyanov pushed a commit that referenced this pull request Jul 23, 2025
Recent refactor of compute-runtime utils, #19303, introduced a
regression that caused IGC dependencies to be fetched into incorrect
directories, causing build failures.

This patch fixes the directory path for IGC directories, allowing the
recent compute-runtime drivers to be built.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants