[NFC][SYCL] Pass queue_impl by raw ptr/ref in event_impl.hpp
#18983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the ongoing refactoring to prefer raw ptr/ref for SYCL RT objects by default with explicit `shared_from_this` when lifetimes need to be extended.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Jun 13, 2025
sycl/source/detail/event_impl.cpp
Outdated
| std::weak_ptr<queue_impl> Queue = isHost() ? MSubmittedQueue : MQueue; | ||
| if (QueueImplPtr QueuePtr = Queue.lock()) { | ||
| device_impl &Device = QueuePtr->getDeviceImpl(); | ||
| if (auto Queue = isHost() ? MSubmittedQueue.lock() : MQueue.lock()) { |
There was a problem hiding this comment.
To be uniform with changes above, plus avoids creation of a weak_ptr copy (which has some overhead: https://godbolt.org/z/YErne5446).
aelovikov-intel
commented
Jun 13, 2025
| @@ -323,13 +323,6 @@ bool Command::isFusable() const { | |||
| } | |||
| #endif // __INTEL_PREVIEW_BREAKING_CHANGES | |||
|
|
|||
| static void flushCrossQueueDeps(const std::vector<EventImplPtr> &EventImpls, | |||
There was a problem hiding this comment.
Moved to be a member function of Command
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
reviewed
Jun 16, 2025
vinser52
reviewed
Jun 16, 2025
vinser52
approved these changes
Jun 16, 2025
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
queue_impl-event_impl
branch
from
c0d9bf5 to
2cfc087
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
force-pushed
the
queue_impl-event_impl
branch
from
2cfc087 to
118a184
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 16, 2025
Continuation of the refactoring efforts in intel#18715 intel#18748 intel#18830 intel#18907 intel#18983
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 16, 2025
Continuation of the refactoring efforts in intel#18715 intel#18748 intel#18830 intel#18907 intel#18983
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 16, 2025
Continuation of the refactoring efforts in intel#18715 intel#18748 intel#18830 intel#18907 intel#18983
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 16, 2025
Continuation of the refactoring efforts in intel#18715 intel#18748 intel#18830 intel#18907 intel#18983
uditagarwal97
approved these changes
Jun 16, 2025
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 17, 2025
Continuation of the refactoring efforts in intel#18715 intel#18748 intel#18830 intel#18907 intel#18983 intel#19004 intel#19006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the ongoing refactoring to prefer raw ptr/ref for SYCL RT objects by default with explicit
shared_from_thiswhen lifetimes need to be extended.