Skip to content

[Benchmarks] Update benchmarks README.md #18954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from

Conversation

wlemkows
Copy link

@wlemkows wlemkows requested a review from a team as a code owner June 12, 2025 14:03
Copy link
Contributor

@PatKamin PatKamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add information on --filter and --preset. I would say that these are as commonly used parameters as the ones already mentioned in this readme.

@@ -9,47 +9,68 @@ Scripts for running performance tests on SYCL and Unified Runtime.
- [LlamaCpp Benchmarks](https://github.com/ggerganov/llama.cpp)
- [SYCL-Bench](https://github.com/unisa-hpc/sycl-bench)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update this list with gromacs (and umf?) benchmark


`$ ./main.py ~/benchmarks_workdir/ --sycl ~/llvm/build/ --ur ~/ur --adapter adapter_name`
Built compiler to be used for benchmarks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could be in bullets

are stored [here](https://oneapi-src.github.io/unified-runtime/performance/).

## Output formats
### Output formats
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the extra # intentional?

Comment on lines +98 to +103
## Contribution

The requirements and instructions above are for building the project from source
without any modifications. To make modifications to the specification, please see the
[Contribution Guide](https://oneapi-src.github.io/unified-runtime/core/CONTRIB.html)
for more detailed instructions on the correct setup.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the UR CONTRIB actually relevant for benchmark scripts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants