Skip to content

[CI] Run L0 v2 tests on PVC #18909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[CI] Run L0 v2 tests on PVC #18909

wants to merge 3 commits into from

Conversation

igchor
Copy link
Member

@igchor igchor commented Jun 10, 2025

No description provided.

@igchor igchor temporarily deployed to WindowsCILock June 10, 2025 21:41 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 10, 2025 22:27 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 10, 2025 22:27 — with GitHub Actions Inactive
@igchor igchor marked this pull request as ready for review June 11, 2025 22:23
@igchor igchor requested review from a team as code owners June 11, 2025 22:23
@igchor igchor temporarily deployed to WindowsCILock June 11, 2025 22:26 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 11, 2025 23:09 — with GitHub Actions Inactive
@igchor
Copy link
Member Author

igchor commented Jun 13, 2025

@intel/dpcpp-devops-reviewers @intel/sycl-matrix-reviewers could you please take a look? Enabling v2 testing doesn't seem to increase testing time at all (probably the bottleneck is just in dispatching the tests).

@uditagarwal97
Copy link
Contributor

uditagarwal97 commented Jun 13, 2025

@intel/dpcpp-devops-reviewers @intel/sycl-matrix-reviewers could you please take a look? Enabling v2 testing doesn't seem to increase testing time at all (probably the bottleneck is just in dispatching the tests).

I think there is an overhead:
E2E on PVC for this PR: 7m 18sec (https://github.com/intel/llvm/actions/runs/15597044541/job/44073154508?pr=18909)
E2E on PVC for last Nightly run (same PVC runner): 3m 38sec (https://github.com/intel/llvm/actions/runs/15625712272/job/44019756304)

Nevertheless, I think that we have enough PVC machines to accommodate L0 V2 testing, without it becoming the bottleneck.
Edit:- I'll wait for @sarnex to share his thoughts before approving the PR.

@igchor
Copy link
Member Author

igchor commented Jun 13, 2025

@intel/dpcpp-devops-reviewers @intel/sycl-matrix-reviewers could you please take a look? Enabling v2 testing doesn't seem to increase testing time at all (probably the bottleneck is just in dispatching the tests).

I think there is an overhead: E2E on PVC for this PR: 7m 18sec (https://github.com/intel/llvm/actions/runs/15597044541/job/44073154508?pr=18909) E2E on PVC for last Nightly run (same PVC runner): 3m 38sec (https://github.com/intel/llvm/actions/runs/15625712272/job/44019756304)

Nevertheless, I think that we have enough PVC machines to accommodate L0 V2 testing, without it becoming the bottleneck. Edit:- I'll wait for @sarnex to share his thoughts before approving the PR.

Hm, that's interesting. I looked at some other PRs and it seems the time varies quite a lot. For example, here https://github.com/intel/llvm/actions/runs/15632385788/job/44041538881?pr=18970 the Run E2E Tests takes almost exactly the same as on this PR

@uditagarwal97
Copy link
Contributor

@intel/dpcpp-devops-reviewers @intel/sycl-matrix-reviewers could you please take a look? Enabling v2 testing doesn't seem to increase testing time at all (probably the bottleneck is just in dispatching the tests).

I think there is an overhead: E2E on PVC for this PR: 7m 18sec (https://github.com/intel/llvm/actions/runs/15597044541/job/44073154508?pr=18909) E2E on PVC for last Nightly run (same PVC runner): 3m 38sec (https://github.com/intel/llvm/actions/runs/15625712272/job/44019756304)
Nevertheless, I think that we have enough PVC machines to accommodate L0 V2 testing, without it becoming the bottleneck. Edit:- I'll wait for @sarnex to share his thoughts before approving the PR.

Hm, that's interesting. I looked at some other PRs and it seems the time varies quite a lot. For example, here https://github.com/intel/llvm/actions/runs/15632385788/job/44041538881?pr=18970 the Run E2E Tests takes almost exactly the same as on this PR

True, there's quite a significant variation between PVC E2E test runs among different runners, probably because of the differences in compute resources.
https://github.com/intel/llvm/actions/runs/15632385788/job/44041538881?pr=18970 uses a different runner then the CI run of this PR, so, not an apple-to-apple comparison 🍎.

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. I think we have a bit of room left on PVC GPU testing, so I'm willing to try it. @igchor when we merge this please make a note to check pvc e2e runtimes for a few days/a week after to make sure there is no huge slowdown. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants