Skip to content

[SYCL][UR][L0 v2] get rid of std::function in memory.hpp #18655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL][UR][L0 v2] get rid of std::function in memory.hpp #18655

wants to merge 1 commit into from

Conversation

igchor
Copy link
Member

@igchor igchor commented May 23, 2025

There migration logic is always the same, there's no need to pass callback to every getDevicePtr/map/unmap function.

@igchor igchor requested review from a team as code owners May 23, 2025 16:39
@igchor igchor requested a review from fabiomestre May 23, 2025 16:39
@igchor igchor force-pushed the no_std_function branch from 62095a5 to acd3da9 Compare May 23, 2025 17:00
@igchor igchor temporarily deployed to WindowsCILock May 23, 2025 17:01 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 23, 2025 17:20 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 23, 2025 17:20 — with GitHub Actions Inactive
@igchor
Copy link
Member Author

igchor commented May 28, 2025 •
edited
Loading

@intel/sycl-graphs-reviewers could you please take a look? this is relatively simple change

@pbalcer
Copy link
Contributor

pbalcer commented May 29, 2025

@igchor you need to rebase.

@igchor igchor force-pushed the no_std_function branch from acd3da9 to cc3ea3c Compare May 29, 2025 15:29
@igchor igchor temporarily deployed to WindowsCILock May 29, 2025 15:29 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 29, 2025 16:02 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 29, 2025 16:02 — with GitHub Actions Inactive
@igchor
[SYCL][UR][L0 v2] get rid of std::function in memory.hpp
cc3ea3c 
There migration logic is always the same, there's no
need to pass callback to every getDevicePtr/map/unmap
function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

@pbalcer pbalcer pbalcer approved these changes

@fabiomestre fabiomestre Awaiting requested review from fabiomestre fabiomestre is a code owner automatically assigned from intel/sycl-graphs-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igchor @pbalcer @EwanC