[SYCL][CMake] Garbage-collect in libsycl linking #18293
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the -Wl,--gc-sections flags to the linking of the SYCL libraries when available. This enables link-time section garbage collection, removing dead code in the binary, potentially reducing the size of it. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Locally observed libsycl.so size change on Linux: 5401440 -> 5280472 Size difference is even more significant with #16763. |
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
May 2, 2025
|
Recording from offline discussion: From https://gcc.gnu.org/onlinedocs/gnat_ugn/Compilation-options.html:
Need to ensure that all our object files are compiled with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the -Wl,--gc-sections flags to the linking of the SYCL libraries when available. This enables link-time section garbage collection, removing dead code in the binary, potentially reducing the size of it.