[UR][Offload] Add initial Offload adapter #18271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumfare
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
callumfare
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
callumfare
force-pushed
the
offload_adapter
branch
from
2278ccd to
b7c161d
Compare
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
force-pushed
the
offload_adapter
branch
from
b7c161d to
1fe1406
Compare
callumfare
force-pushed
the
offload_adapter
branch
from
1fe1406 to
3794a92
Compare
kbenzie
reviewed
May 1, 2025
callumfare
force-pushed
the
offload_adapter
branch
from
1c25c33 to
489d3b8
Compare
callumfare
force-pushed
the
offload_adapter
branch
from
489d3b8 to
b42db9e
Compare
RossBrunton
force-pushed
the
offload_adapter
branch
from
9ccf90c to
5e38ab4
Compare
RossBrunton
force-pushed
the
offload_adapter
branch
from
5e38ab4 to
d9923f1
Compare
|
@intel/unified-runtime-reviewers Can I get this looked at when people get the chance? |
This makes the dependency on cudadrv optional and ifdefs away the cubin workaround if it isn't. This isn't sufficient to have HIP devices compile kernels, but does allow libur_adapter_offload to be built on said hosts. In addition, an unused variable error was fixed.
This adds "offload" to several locations, meaning that: * It will be initialised by the loader and iterated like other adapters. * ONEAPI_DEVICE_SELECTOR="offload:*" works (note that this is an extension to the ONEAPI_DEVICE_SELECTOR format). * Platforms and adapters now report themselves as "OFFLOAD" rather than "CUDA" or "HIP".
It is non-trivial which binary format (spir, ptx, amdhsa) is accepted by a given offload device. This should be fixed properly in the future, but for now let the user specify it via an environment variable.
SYCL and the UR CTS produce HIP "offload bundles" when compiling for AMDGPU, which cannot be accepted by the basic AMD offload plugin. This change adds a simple offload bundle parser which extracts the appropriate binary from the bundle, allowing it to be fed to liboffload.
RossBrunton
force-pushed
the
offload_adapter
branch
from
d9923f1 to
f18ca23
Compare
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the initial implementation of the Offload adapter for UR.
The adapter targets the new liboffload library in LLVM.
The adapter is experimental and is currently only maintained to drive development of liboffload by identifying and closing gaps with UR.