[Clang][Doc][NFC] Improve -offload-compress documentation and error message
#17990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
changed the title
zstd and -offload-compress documentation and error message-offload-compress documentation and error message
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
This was referenced Apr 12, 2025
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Apr 14, 2025
sycl/doc/GetStartedGuide.md
Outdated
| ```sh | ||
| sudo apt-get install libzstd-dev | ||
| ``` | ||
| Note that the libzstd-dev package provided on Ubuntu 24.04 has a bug and the zstd static library is not built with `-fPIC` flag. Linking to this library will result in a build failure. For example: [Issue#15935](https://github.com/intel/llvm/issues/15935). As an alternative, zstd can be built from source either manually or by using the [build_zstd_1_5_6_ub24.sh](https://github.com/intel/llvm/blob/sycl/devops/scripts/build_zstd_1_5_6_ub24.sh) script. |
There was a problem hiding this comment.
might be helpful to link to the launchpad bug here so people can know when its fixed
There was a problem hiding this comment.
Sure. Done in d498a14
| @@ -134,6 +134,9 @@ def do_configure(args, passthrough_args): | |||
| if args.use_lld: | |||
| llvm_enable_lld = "ON" | |||
|
|
|||
| if args.use_zstd: | |||
There was a problem hiding this comment.
do we want to use this in ci_defaults?
There was a problem hiding this comment.
Sure, but let's do that change in a separate PR. I am not sure if the new Windows machine that we recently added (on VM) has zstd installed.
There was a problem hiding this comment.
i should have installed it everywhere but yeah a separate pr is fine
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Apr 15, 2025
|
@steffenlarsen ping. |
Co-authored-by: Steffen Larsen <[email protected]>
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the user's feedback in #17957 and #17914