Skip to content

[UR] Retain and release device handles for sub-devices #17977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

[UR] Retain and release device handles for sub-devices #17977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions unified-runtime/source/adapters/opencl/device.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ struct ur_device_handle_t_ {
RefCount = 1;
if (Parent) {
Type = Parent->Type;
[[maybe_unused]] auto Res = clRetainDevice(CLDevice);
assert(Res == CL_SUCCESS);
} else {
[[maybe_unused]] auto Res = clGetDeviceInfo(
CLDevice, CL_DEVICE_TYPE, sizeof(cl_device_type), &Type, nullptr);
Expand All @@ -41,6 +43,8 @@ struct ur_device_handle_t_ {
// exactly once. However, to prevent issues with the OpenCL handle being
// reused, CLDevice must still be alive here.
Platform->SubDevices.erase(CLDevice);
[[maybe_unused]] auto Res = clReleaseDevice(CLDevice);
assert(Res == CL_SUCCESS);
}
if (ParentDevice && IsNativeHandleOwned) {
clReleaseDevice(CLDevice);
Expand Down