[DeviceMSAN] Use device usm to allocate LaunchInfo #17948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZyne
commented
Apr 10, 2025
| @@ -339,6 +339,7 @@ void __asan_exit(ErrorType error_type) { | |||
| __devicelib_exit(); | |||
| break; | |||
| default: | |||
| break; | |||
There was a problem hiding this comment.
fix compile warning
AllanZyne
changed the title
yingcong-wu
reviewed
Apr 10, 2025
unified-runtime/source/loader/layers/sanitizer/msan/msan_interceptor.hpp
Outdated
Show resolved
Hide resolved
yingcong-wu
approved these changes
Apr 10, 2025
|
@intel/unified-runtime-reviewers, please review. Thanks! |
yingcong-wu
approved these changes
Apr 11, 2025
aarongreig
reviewed
Apr 11, 2025
| Result = getContext()->urDdiTable.USM.pfnFree(Context, (void *)Data); | ||
| MsanRuntimeDataWrapper::~MsanRuntimeDataWrapper() { | ||
| if (Host.CleanShadow) { | ||
| auto Result = |
There was a problem hiding this comment.
I think we still need the [[maybe_unused]] for this and the declaration below, assert doesn't always count as using a variable
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cts segment fault on accessing shared usm