[SYCL] Correct spec about constness of get(properties_tag) member and add respective warning #17947
+110
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…respective warning Signed-off-by: Hu, Peisen <[email protected]>
againull
reviewed
Apr 10, 2025
ProGTX
approved these changes
Apr 11, 2025
Signed-off-by: Hu, Peisen <[email protected]>
againull
approved these changes
Apr 11, 2025
gmlueck
approved these changes
Apr 14, 2025
|
Requesting @intel/llvm-gatekeepers to merge this. Thanks! |
| @@ -338,7 +338,7 @@ struct KernelFunctor { | |||
| a[i] = b[i] + c[i]; | |||
| } | |||
|
|
|||
| auto get(sycl::ext::oneapi::experimental::properties_tag) { | |||
| auto get(sycl::ext::oneapi::experimental::properties_tag) const { | |||
There was a problem hiding this comment.
@Pennycook , I think there was some other PR where it was decided that kernel properties can't be runtime. Should we change this to static constexpr instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some of our docs suggest using
get(properties_tag) {...}member in kernel functors to specify kernel properties while some suggest usingget(properties_tag) const {...}. But actuallyget(properties_tag) {...}might not work under certain conditions, so we should update the incorrect docs that they suggest readers to useget(properties_tag) const {...}rather thanget(properties_tag) {...}.Also as @Pennycook suggested, added a diagnostic warning to indicate the user when:
-they have declared a
get(properties_tag)member in the kernel functorAND
-they declared
get(properties_tag){...}rather thanget(properties_tag) const {...}Updated the tests containing the non-const version of
get(properties_tag)as well.