Enable cmake argument passthrough in the SYCL configure wrapper (#17189) #17587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hundreds of `--cmake-opt=-DFOO=BAR` on the command line make it hard to see the wood for the trees, so introduce an alternative which is to simply pass unknown argument flags straight through to cmake. This should make using the wrapper a little more pleasant and readable.
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sarnex
approved these changes
Mar 21, 2025
|
Do we need that because we use CI from trunk? |
yep that's it |
AlexeySachkov
approved these changes
Mar 23, 2025
|
Fails can be ignored as we use nightly to test the branch. @AlexeySachkov please merge |
AlexeySachkov
deleted the
cherry-pick-c62abaeee9e6cb48d04fb623075705710089bd3f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hundreds of
--cmake-opt=-DFOO=BARon the command line make it hard to see the wood for the trees, so introduce an alternative which is to simply pass unknown argument flags straight through to cmake. This should make using the wrapper a little more pleasant and readable.CHERRY-PICK OF: c62abae