[UR] Share generic error handling between adapters #17576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `UR_ASSERT`: Remove redefinition in L0 adapter. * `die()`: Use `logger` and remover redefinitions in 4 adapters. * `UR_CALL*`: Move from L0 to shared `ur.hpp`, used in sanitizer layer and other adapters.
kbenzie
reviewed
Mar 21, 2025
Contributor
|
Overall these a nice changes. |
hvdijk
approved these changes
Mar 24, 2025
reble
approved these changes
Mar 24, 2025
Contributor
reble
left a comment
reble
left a comment
There was a problem hiding this comment.
LGTM for sycl graph related changes
aarongreig
approved these changes
Mar 24, 2025
Contributor
Author
|
@intel/llvm-gatekeepers this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR_ASSERT: Remove redefinition in L0 adapter.die(): Useloggerand remover redefinitions in 4 adapters.UR_CALL*: Move from L0 to sharedur.hpp, used in sanitizer layer and other adapters.