[SYCL] Optimize use of shared_ptr on kernel enqueue fast path #17569
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
vinser52
reviewed
Mar 21, 2025
Use references to shared_ptr as local variables.
Pass the ContextImplPtr by reference to selected functions (on the kernel enqueue fast path).
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
changed the title
vinser52
requested changes
Mar 24, 2025
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
slawekptak
force-pushed
the
shared_ptrs_refs_local_vars_2
branch
from
12430be to
bdcd30e
Compare
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
reviewed
Mar 25, 2025
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
directly, instead of creating the device object instance.
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
vinser52
approved these changes
Mar 25, 2025
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
requested a deployment
to
WindowsCILock
GitHub Actions
Queued
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
approved these changes
Mar 25, 2025
fabiomestre
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a series of optimizations to how the shared_ptr type variables are passed, to minimize the number of reference counter increments and decrements.