[SYCL][COMPAT] Move non-e2e tests to correct dir #15828
Conversation
These tests never run the compiled code, so belong in `sycl/test`
joeatodd
force-pushed
the
jtodd/move_tests
branch
from
56bbd41 to
544c4c8
Compare
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -23,7 +23,7 @@ | |||
| // We need hardware which can support at least 2 sub-group sizes, since that | |||
| // hardware (presumably) supports the `intel_reqd_sub_group_size` attribute. | |||
| // REQUIRES: sg-32 && sg-16 | |||
| // RUN: %{build} %if cl_options %{/clang:-S /clang:-emit-llvm%} %else %{-S -emit-llvm%} -o - | FileCheck %s | |||
There was a problem hiding this comment.
@ayylol I'd really appreciate your advice here. I rebased after #15744 was merged. I have removed the %if cl_options clause here, because I think %clangxx (and the fact I've moved the test from sycl/test-e2e to sycl/test) means that I don't need it, but I'm not confident about that. Is this OK or am I undoing your work?
There was a problem hiding this comment.
Hey @joeatodd I am not so familiar with the how the tests in test function to know right away if this would not cause any issues, however I can describe what was needed to reproduce the issue when it was in the e2e folder so you can check if it is needed after you move it.
in test-e2e the compiler used in %clangxx is set via the CMAKE_CXX_COMPILER flag. Setting this to clang-cl on windows is what made the warning be emitted, due to the -emit-llvm flag not existing on the MSVC driver. Because the e2e tests also add the -Werror flag to the %clangxx expansion this created a failure.
There was a problem hiding this comment.
Thanks for the info 🙏
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers this is ready to merge 🙏 |
This PR moves tests which don't execute anything on a device into
sycl/test/syclcompatinstead ofsycl/test-e2e/syclcompat/.Also fix an issue with
kernel_properties.cpptest setup.