Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Joint Matrix][E2E] Remove xfail from Joint Matrix runtime dimension tests #15784

Merged

Conversation

YixingZhang007
Copy link
Contributor

@YixingZhang007 YixingZhang007 commented Oct 21, 2024

Description:
The failure of the tests joint_matrix_bf16_fill_k_cache_arg_dim.cpp and joint_matrix_bf16_fill_k_cache_runtime_dim.cpp has been addressed in commit intel/intel-graphics-compiler@92236dc. The commit solves the issue by changing the Acc 32x64 and Acc 32x32 matrix types from using the array type [2 x <float x 64>] to a structure type { <float x 64>, <float x 64> }

@YixingZhang007 YixingZhang007 requested a review from a team as a code owner October 21, 2024 18:45
@YixingZhang007 YixingZhang007 marked this pull request as draft October 21, 2024 18:45
@YixingZhang007 YixingZhang007 self-assigned this Oct 21, 2024
@YixingZhang007 YixingZhang007 changed the title Remove xfail from Joint Matrix runtime dimension tests [SYCL][Joint Matrix][E2E] Remove xfail from Joint Matrix runtime dimension tests Oct 21, 2024
@YixingZhang007 YixingZhang007 marked this pull request as ready for review October 22, 2024 19:58
@YixingZhang007 YixingZhang007 requested a review from a team as a code owner October 22, 2024 19:58
@YuriPlyakhin
Copy link
Contributor

Description: The failure of the tests joint_matrix_bf16_fill_k_cache_arg_dim.cpp and joint_matrix_bf16_fill_k_cache_runtime_dim.cpp has been addressed in IGC PR #15429. The IGC PR solves the issue by changing the Acc 32x64 and Acc 32x32 matrix types from using the array type [2 x <float x 64>] to a structure type { <float x 64>, <float x 64> }

@YixingZhang007 , link to IGC PR #15429 seems to be incorrect. it points to intel/llvm PR. I think you can refer to this commit: intel/intel-graphics-compiler@92236dc which is in open source repo.

@YixingZhang007
Copy link
Contributor Author

YixingZhang007 commented Oct 22, 2024

Description: The failure of the tests joint_matrix_bf16_fill_k_cache_arg_dim.cpp and joint_matrix_bf16_fill_k_cache_runtime_dim.cpp has been addressed in IGC PR #15429. The IGC PR solves the issue by changing the Acc 32x64 and Acc 32x32 matrix types from using the array type [2 x <float x 64>] to a structure type { <float x 64>, <float x 64> }

@YixingZhang007 , link to IGC PR #15429 seems to be incorrect. it points to intel/llvm PR. I think you can refer to this commit: intel/intel-graphics-compiler@92236dc which is in open source repo.

Sorry for the mistake! I have updated the link. Thanks!

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YixingZhang007
Copy link
Contributor Author

@intel/llvm-gatekeepers, please help merge this PR. Thanks!

@martygrant
Copy link
Contributor

@YixingZhang007 still needs approval from @intel/llvm-reviewers-runtime and there is one conflict to resolve

…joint_matrix_bf16_fill_k_cache_runtime_dim.cpp
@YixingZhang007
Copy link
Contributor Author

@intel/llvm-gatekeepers , the PR has been approved and all tests have passed. Could you please help merge this PR? Thanks!

@martygrant martygrant merged commit 21a6054 into intel:sycl Oct 24, 2024
12 checks passed
YixingZhang007 added a commit to YixingZhang007/llvm that referenced this pull request Oct 30, 2024
…nsion tests (intel#15784)

Description: 
The failure of the tests joint_matrix_bf16_fill_k_cache_arg_dim.cpp and
joint_matrix_bf16_fill_k_cache_runtime_dim.cpp has been addressed in
commit
intel/intel-graphics-compiler@92236dc.
The commit solves the issue by changing the Acc 32x64 and Acc 32x32
matrix types from using the array type [2 x <float x 64>] to a structure
type { <float x 64>, <float x 64> }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants