-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Joint Matrix][E2E] Remove xfail from Joint Matrix runtime dimension tests #15784
[SYCL][Joint Matrix][E2E] Remove xfail from Joint Matrix runtime dimension tests #15784
Conversation
@YixingZhang007 , link to IGC PR #15429 seems to be incorrect. it points to intel/llvm PR. I think you can refer to this commit: intel/intel-graphics-compiler@92236dc which is in open source repo. |
Sorry for the mistake! I have updated the link. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@intel/llvm-gatekeepers, please help merge this PR. Thanks! |
@YixingZhang007 still needs approval from @intel/llvm-reviewers-runtime and there is one conflict to resolve |
f46612a
to
3be2cc5
Compare
…joint_matrix_bf16_fill_k_cache_runtime_dim.cpp
3be2cc5
to
3c116e6
Compare
@intel/llvm-gatekeepers , the PR has been approved and all tests have passed. Could you please help merge this PR? Thanks! |
…nsion tests (intel#15784) Description: The failure of the tests joint_matrix_bf16_fill_k_cache_arg_dim.cpp and joint_matrix_bf16_fill_k_cache_runtime_dim.cpp has been addressed in commit intel/intel-graphics-compiler@92236dc. The commit solves the issue by changing the Acc 32x64 and Acc 32x32 matrix types from using the array type [2 x <float x 64>] to a structure type { <float x 64>, <float x 64> }
Description:
The failure of the tests joint_matrix_bf16_fill_k_cache_arg_dim.cpp and joint_matrix_bf16_fill_k_cache_runtime_dim.cpp has been addressed in commit intel/intel-graphics-compiler@92236dc. The commit solves the issue by changing the Acc 32x64 and Acc 32x32 matrix types from using the array type [2 x <float x 64>] to a structure type { <float x 64>, <float x 64> }