[SYCL] Update calls_indirectly property #15523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows calls_indirectly property to handle all passed template arguments, but not the only first one. Also applying some minor changes to the spec. Spec & Design: intel#10540
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
I think @AlexeySachkov's comment is solid, but aside from that and a small nit, LGTM!
sycl/include/sycl/ext/oneapi/experimental/virtual_functions.hpp
Outdated
Show resolved
Hide resolved
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
approved these changes
Oct 1, 2024
|
@AlexeySachkov can we merge this one? |
Yep, I was waiting for CI to finish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows calls_indirectly property to handle all passed template arguments, but not the only first one.
Also applying some minor changes to the spec.
Spec & Design: #10540