Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][NATIVECPU] Update Native CPU attributes test #15451

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

PietroGhg
Copy link
Contributor

Removes the check for __mux_work_group_barrier since on Native CPU work group barriers are materialized by OCK's WorkItemLoopPass, and since now we correctly remove unused functions from the module, there are no more references to __mux_work_group_barrier.

Copy link
Contributor

@uwedolinsky uwedolinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to also have a test with this combination of barrier and atomic_fence that runs (not just checks the device code), but maybe this is already covered by the SYCL-CTS or e2e, or OCK/(OpenCL-CTS) at the OpenCL level.

@PietroGhg
Copy link
Contributor Author

@intel/llvm-gatekeepers this looks ready to merge, thank you

@martygrant martygrant merged commit 7b34aee into intel:sycl Sep 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants