[CI] Skip dev-igc run if the PR has ci-no-devigc label specified
#15318
Conversation
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
added
the
ci-no-devigc
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
@uditagarwal97 LGTM, can you just post the log from a run of dev-igc before the ci-dev-igc label was set, I want to make sure that case is working but I can't find the logs :( |
That's weird. Even I can't find the logs from before. I can remove this label and re-open the PR again, if that helps. |
uditagarwal97
removed
the
ci-no-devigc
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Co-authored-by: Nick Sarnie <[email protected]>
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
| @@ -110,6 +110,8 @@ jobs: | |||
| use_dev_igc: ${{ contains(needs.detect_changes.outputs.filters, 'devigccfg') }} | |||
| extra_lit_opts: --param matrix-xmx8=True --param gpu-intel-dg2=True | |||
| env: '{"LIT_FILTER":${{ needs.determine_arc_tests.outputs.arc_tests }} }' | |||
| # Run only if the PR does not have the 'ci-no-devigc' label. | |||
| skip_run: ${{ contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') && 'true' || 'false' }} | |||
There was a problem hiding this comment.
Do we still need the ( && 'true' || 'false')?
There was a problem hiding this comment.
Yes, because skip_run is of type String
There was a problem hiding this comment.
Actually, you are right. Now that I refer to GHA docs (https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#contains), contains() return true/false strings. Previously, I though contains() returns boolean values.
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
Test failure on Arc is unrelated. I've opened an issue for it: #15321 |
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Currently, if
ci-no-devigclabel is specified, we duplicate the E2E test run withghcr.io/intel/llvm/ubuntu2204_intel_drivers:latestimage.This PR intends to skip the run instead of duplicating.