Skip to content

[SYCL] Rename virtual function properties #14994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexeySachkov
Copy link
Contributor

Corresponding SYCL extension proposal (#10540) has been recently updated to change naming of properties it introduces.

This patch aligns the implementation with the proposed extension spec.

Corresponding SYCL extension proposal (intel#10540) has been
recently updated to change naming of properties it introduces.

This patch aligns the implementation with the proposed extension spec.
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

@AlexeySachkov
Copy link
Contributor Author

CUDA testing failed due to infrastructure issues, but the extension I'm modify here is not supported on CUDA anyway.

The other failure is:

TIMEOUT: SYCL :: OneapiDeviceSelector/case_sensitivity.cpp (2002 of 2129)
******************** TEST 'SYCL :: OneapiDeviceSelector/case_sensitivity.cpp' FAILED ********************
Exit Code: -9
Timeout: Reached timeout of 600 seconds

Command Output (stdout):
--
# RUN: at line 4
/__w/llvm/llvm/toolchain/bin//clang++  -Werror  -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/OneapiDeviceSelector/Inputs/trivial.cpp -o /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -Werror -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/OneapiDeviceSelector/Inputs/trivial.cpp -o /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# note: command had no output on stdout or stderr
# RUN: at line 5
env ONEAPI_DEVICE_SELECTOR="OPENCL:*"  /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# executed command: env 'ONEAPI_DEVICE_SELECTOR=OPENCL:*' /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# .---command stdout------------
# | Device: Intel(R) Iris(R) Xe Graphics
# | Device: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
# | Device: Intel(R) FPGA Emulation Device
# `-----------------------------
# error: command failed with exit status: -9
# error: command reached timeout: True

It does not seem to be related to a PR. I will re-run corresponding testing to double-check, but I think that this PR should be good to go. I will merge it once Linux CI job completes

@AlexeySachkov AlexeySachkov merged commit 08bae91 into intel:sycl Aug 9, 2024
13 of 14 checks passed
AlexeySachkov added a commit to AlexeySachkov/llvm that referenced this pull request Nov 26, 2024
Corresponding SYCL extension proposal (intel#10540) has been
recently updated to change naming of properties it introduces.

This patch aligns the implementation with the proposed extension spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants