[sycl][hip] Exception for unsupported get_native<sycl::context> #14476
+26
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
JackAKirk
changed the title
JackAKirk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: JackAKirk <[email protected]>
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: JackAKirk <[email protected]>
…kAKirk/llvm into test-ur-hip-context-refactor
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
I'll update the FetchUnifiedRuntime to resolve conflicts once approvals are given and oneapi-src/unified-runtime#1830 has been merged. |
|
Hi @uditagarwal97 |
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -51,7 +51,7 @@ int main() { | |||
| // backend-defined and specified in the backend specification. | |||
|
|
|||
| hip_device = get_native<backend::ext_oneapi_hip>(Device); | |||
| // expected-warning@+1{{'get_native<sycl::backend::ext_oneapi_hip, sycl::context>' is deprecated: Context interop is deprecated for HIP. If a native context is required, use hipDevicePrimaryCtxRetain with a native device}} | |||
| // expected-no-diagnostics | |||
| hip_context = get_native<backend::ext_oneapi_hip>(Context); | |||
There was a problem hiding this comment.
I'm curious about why don't we run this LIT test? Since call to get_native<backend::ext_oneapi_hip>(Context) should now be throwing an exception instead of a depreciation warning and to check the exception in LIT test, don't we have to run the test?
There was a problem hiding this comment.
I think that tests in sycl/test/basic_tests are never ran; all runtime tests are in sycl/test-e2e AFAIK. Good point though, I've updated the corresponding test-e2e test to check for the exception. I've also changed the errc from runtime to feature_not_supported.
Thanks.
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Also made exception use feature_not_supported Signed-off-by: JackAKirk <[email protected]>
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Sep 20, 2024
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exception for unsupported get_nativesycl::context specialization for HIP backend.
This was previously marked deprecated. We keep the specialization in order to give an error message to users.