[SYCL][Matrix] Fix checked matrix instructions #13287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhaldi
reviewed
Apr 4, 2024
KseniyaTikhomirova
approved these changes
Apr 12, 2024
MrSidims
force-pushed
the
matrix-checked-fix
branch
from
d09e8c3 to
f16aa85
Compare
|
Warning comes from unused stride of checked fill API. There should be no such parameter, it also doesn't exist in the spec. I'll remove it in this PR. |
ficol
reviewed
Apr 26, 2024
| size_t CoordY) { | ||
| #if defined(__SYCL_DEVICE_ONLY__) | ||
| using storage_element_type = | ||
| typename oneapi::detail::jm_type_interpretation_helper_trait< | ||
| T>::storage_element_type; | ||
| Res.spvm = __spirv_CooperativeMatrixConstructCheckedINTEL< | ||
| storage_element_type, T, NumRows, NumCols, | ||
| storage_element_type, T, CoordX, CoordY, NumRows, NumCols, |
There was a problem hiding this comment.
Suggested change
| storage_element_type, T, CoordX, CoordY, NumRows, NumCols, | |
| storage_element_type, T, NumRows, NumCols, |
I think it shouldn't be added (these template args correspond to spirv_ops.hpp:48-51)
| size_t CoordY, __spv::MatrixLayout Layout = L, __spv::Scope::Flag Sc = S, | ||
| int MemOperand = 0); | ||
| extern __DPCPP_SYCL_EXTERNAL void __spirv_CooperativeMatrixStoreCheckedINTEL( | ||
| T *Ptr, size_t CoordX, size_t CoordY, |
There was a problem hiding this comment.
Is it ok that CoordX, CoordY are size_t? In SPV_INTEL_joint_matrix.asciidoc, there is "X offset must be a scalar 32-bit integer type".
There was a problem hiding this comment.
It should be int32_t signed, it was fixed in another patch and after rebase it's brough here. Thanks!
There were incorrectly named and had incorrect operands. See intel#12497 Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
force-pushed
the
matrix-checked-fix
branch
from
3200cd0 to
3d41e97
Compare
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
|
@intel/llvm-gatekeepers please help with the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were incorrectly named and had incorrect operands.
See #12497