Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] wait_and_throw invokes asynchronous handlers linked to the events that the event depends on. #12202

Open
wants to merge 11 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] wait_and_throw invokes asynchronous handlers linked to the events that the event depends on. #12202

wants to merge 11 commits into from

Conversation

mmoadeli
Copy link
Contributor

@mmoadeli mmoadeli commented Dec 18, 2023 •
edited
Loading

Modifies wait_and_throw to invoke asynchronous handlers linked to the events that an event depends on.
There is a corresponding PR to clarify specification.

@mmoadeli mmoadeli requested a review from a team as a code owner December 18, 2023 22:00
@mmoadeli mmoadeli changed the title [SYCL] Invoke asynchronous handlers linked to the events that the occurrence of an event relies on. [SYCL] Modifies wait_and_throw to invoke asynchronous handlers linked to the events that the occurrence of an event relies on. Dec 18, 2023
@mmoadeli mmoadeli changed the title [SYCL] Modifies wait_and_throw to invoke asynchronous handlers linked to the events that the occurrence of an event relies on. [SYCL] Modifies wait_and_throw to invoke asynchronous handlers linked to the events that an event depends on. Dec 18, 2023
@mmoadeli mmoadeli changed the title [SYCL] Modifies wait_and_throw to invoke asynchronous handlers linked to the events that an event depends on. [SYCL] wait_and_throw invokes asynchronous handlers linked to the events that an event depends on. Dec 18, 2023
@mmoadeli mmoadeli marked this pull request as draft December 18, 2023 23:02
@mmoadeli mmoadeli force-pushed the dependent-async-handler branch from d0ad857 to 764f4e9 Compare December 19, 2023 00:00
@mmoadeli mmoadeli marked this pull request as ready for review December 19, 2023 00:02
@mmoadeli mmoadeli force-pushed the dependent-async-handler branch from 764f4e9 to bf9a906 Compare December 19, 2023 00:04
@mmoadeli mmoadeli changed the title [SYCL] wait_and_throw invokes asynchronous handlers linked to the events that an event depends on. [SYCL] wait_and_throw invokes asynchronous handlers linked to the events that the event depends on. Dec 19, 2023
steffenlarsen
steffenlarsen approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmoadeli
Copy link
Contributor Author

mmoadeli commented Jan 8, 2024

@dm-vodopyanov a friendly request for review please.

@mmoadeli
Copy link
Contributor Author

mmoadeli commented Jan 18, 2024 •
edited
Loading

@dm-vodopyanov, @Naghasan a friendly request for review please.

@AlexeySachkov
Copy link
Contributor

@mmoadeli, the PR doesn't require any extra approvals, since @steffenlarsen is a member of runtime-reviewers team. However, I'm a bit hesitant to merge it right now considering that the spec PR is still open (even though it is approved). Tagging @gmlueck as one of the reviewers for extra inputs.

Besides that, I wonder if this should be considered as a breaking change and put under -fpreview-breaking-changes mode? Note: I haven't looked into this or the spec PRs, just asking blindly to double-check

@mmoadeli
Copy link
Contributor Author

@mmoadeli, the PR doesn't require any extra approvals, since @steffenlarsen is a member of runtime-reviewers team. However, I'm a bit hesitant to merge it right now considering that the spec PR is still open (even though it is approved). Tagging @gmlueck as one of the reviewers for extra inputs.

Besides that, I wonder if this should be considered as a breaking change and put under -fpreview-breaking-changes mode? Note: I haven't looked into this or the spec PRs, just asking blindly to double-check

thanks @AlexeySachkov

@github-actions GitHub Actions
Copy link
Contributor

This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days.

@github-actions github-actions bot added the Stale label Sep 26, 2024
@mmoadeli
Copy link
Contributor Author

mmoadeli commented Oct 2, 2024

@AerialMantis It seems the corresponding spec PR is merged. Could this be merged in?

@github-actions github-actions bot removed the Stale label Oct 3, 2024
@npmiller npmiller requested review from a team and bader as code owners February 27, 2025 17:57
@npmiller npmiller removed request for a team February 27, 2025 18:00
@npmiller
Copy link
Contributor

Apologies for the extra ping from a bad merge, the reviewers should be correct now

@bader bader removed their request for review February 27, 2025 18:26
cperkinsintel
cperkinsintel reviewed Feb 28, 2025
View reviewed changes
sycl/test-e2e/Basic/dependent_event_async_exception.cpp

e2.wait_and_throw();

assert(data1 == 10);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this works, because we are using host tasks.

But is this really guaranteed, that the buffer's backstopping data will be correctly updated even though the kernel that updated it threw an exception?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperkinsintel cperkinsintel cperkinsintel left review comments

@AerialMantis AerialMantis AerialMantis left review comments

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@dm-vodopyanov dm-vodopyanov Awaiting requested review from dm-vodopyanov dm-vodopyanov is a code owner automatically assigned from intel/llvm-reviewers-runtime

@Naghasan Naghasan Awaiting requested review from Naghasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmoadeli @AlexeySachkov @steffenlarsen @npmiller @cperkinsintel @AerialMantis