Skip to content

Commit

Permalink
[SYCL][NFC] Re-enable sycl.c test on Windows (#15433)
Browse files Browse the repository at this point in the history
The issue dealt with the resetting of the PATH environment variable.
This was masking potential runtime dependencies (DLLs and such) for
other tools being used when running the test. The solution is to append
the PATH for the dummy `aoc` instead of overwriting.
  • Loading branch information
mdtoguchi committed Sep 20, 2024
1 parent 9f53a78 commit c0b49db
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions clang/test/Driver/sycl.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
// Failing on Windows - temporarily disable
// REQUIRES: system-linux

// RUN: %clang -### -fsycl -c %s 2>&1 | FileCheck %s --check-prefix=ENABLED
// RUN: %clang -### -fsycl %s 2>&1 | FileCheck %s --check-prefix=ENABLED
// RUN: %clang -### -fno-sycl -fsycl %s 2>&1 | FileCheck %s --check-prefix=ENABLED
Expand Down Expand Up @@ -107,7 +104,7 @@
// Test with a bad argument is expected to fail
// RUN: not %clang -fsycl-help=foo %s 2>&1 | FileCheck %s --check-prefix=SYCL-HELP-BADARG
// RUN: %clang -### -fsycl-help=gen %s 2>&1 | FileCheck %s --check-prefix=SYCL-HELP-GEN
// RUN: env PATH=%t-sycl-dir %clang -### -fsycl-help=fpga %s 2>&1 | FileCheck %s --check-prefixes=SYCL-HELP-FPGA,SYCL-HELP-FPGA-OUT -DDIR=%t-sycl-dir
// RUN: env "PATH=%t-sycl-dir%{pathsep}%PATH%" %clang -### -fsycl-help=fpga %s 2>&1 | FileCheck %s --check-prefixes=SYCL-HELP-FPGA,SYCL-HELP-FPGA-OUT -DDIR=%t-sycl-dir
// RUN: %clang -### -fsycl-help=x86_64 %s 2>&1 | FileCheck %s --check-prefix=SYCL-HELP-CPU
// RUN: %clang -### -fsycl-help %s 2>&1 | FileCheck %s --check-prefixes=SYCL-HELP-GEN,SYCL-HELP-FPGA,SYCL-HELP-CPU
// SYCL-HELP-BADARG: unsupported argument 'foo' to option '-fsycl-help='
Expand Down

0 comments on commit c0b49db

Please sign in to comment.