-
Notifications
You must be signed in to change notification settings - Fork 25
Nix flake packaging #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@pseudocc , can you provide a more detailed reason why this PR should be merged? How does this change apply to Nix main repository? I am not familiar with NixOS, any guidance would be appreciated |
@jwludzik Sorry for the late reply, was enjoying the Chinese New Year holidays and missed your comment. This "flake.nix" for Nix packages is more like a PPA for debs, it is more flexible (users might still want to use state version 23.05, 23.11, etc. Then the nix-flake can help them getting this package without update the main channel that leads to a completely nixos rebuild), these commits do not affect the Nix main repository, but I may create PR for this firmware package in the NixOS/nixpkgs later on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for packaging this repo. its awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!!!
So NixOS users can load the firmware.
Test
On my ThinkPad X13 Yoga Gen5, good.
My flake
pseudocc/nix-config@27ee1af