Change 2D block store from OCL to SPV #3766
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitneywhtsang
force-pushed
the
whitneywhtsang/spirv_2dblockstore
branch
from
8e26c9f to
b8691e3
Compare
Signed-off-by: Whitney Tsang <[email protected]>
whitneywhtsang
force-pushed
the
whitneywhtsang/spirv_2dblockstore
branch
from
b8691e3 to
2c181eb
Compare
etiotto
approved these changes
Mar 27, 2025
Comment on lines
+15
to
+18
| // CHECK-NEXT: [[ElemSize:%.*]] = llvm.mlir.constant(1 : i32) : i32 | ||
| // CHECK-NEXT: [[TileWidth:%.*]] = llvm.mlir.constant(16 : i32) : i32 | ||
| // CHECK-NEXT: [[TileHeight:%.*]] = llvm.mlir.constant(8 : i32) : i32 | ||
| // CHECK-NEXT: [[VBlocks:%.*]] = llvm.mlir.constant(1 : i32) : i32 |
There was a problem hiding this comment.
Use CHECK-DAG for the constants
Comment on lines
+31
to
+33
| // CHECK-NEXT: [[TileWidth:%.*]] = llvm.mlir.constant(32 : i32) : i32 | ||
| // CHECK-NEXT: [[TileHeight:%.*]] = llvm.mlir.constant(8 : i32) : i32 | ||
| // CHECK-NEXT: [[VBlocks:%.*]] = llvm.mlir.constant(1 : i32) : i32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPEC: SPV_INTEL_2d_block_io
Current Agama doesn't yet support the SPV extension, so test failures are expected.
Closes #3752