Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Enable test_matmul::test_mxfp #3679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TEST] Enable test_matmul::test_mxfp #3679

wants to merge 1 commit into from

Conversation

AndreyPavlenko
Copy link
Contributor

@AndreyPavlenko AndreyPavlenko commented Mar 14, 2025 •
edited
Loading

Skip test in case of out of shared memory and another 2 cases due to #3677.
Related to #3307

@AndreyPavlenko AndreyPavlenko changed the title [TEST] Enable test_matmul::test_matmul [TEST] Enable test_matmul::test_mxfp Mar 14, 2025
@whitneywhtsang
Copy link
Contributor

test_matmul::test_mxfp failures on LTS:

[gw4] [ 98%] FAILED language/test_matmul.py::test_mxfp[0-8-3-256-128-128-128-128-128] 
language/test_matmul.py::test_mxfp[0-8-3-256-128-128-2-4-32] 
[gw4] [ 98%] FAILED language/test_matmul.py::test_mxfp[0-8-3-256-128-128-2-4-32] 
language/test_matmul.py::test_mxfp[0-8-3-256-128-128-2-4-64] 
[gw4] [ 98%] FAILED language/test_matmul.py::test_mxfp[0-8-3-256-128-128-2-4-64] 
language/test_matmul.py::test_mxfp[0-8-3-256-128-128-256-16-32] 
[gw4] [ 98%] FAILED language/test_matmul.py::test_mxfp[0-8-3-256-128-128-256-16-32] 
...

Let's add them to the LTS skiplist first in this PR and then continue investigation?

@AndreyPavlenko
Copy link
Contributor Author

Let's add them to the LTS skiplist first in this PR and then continue investigation?

Done.

@AndreyPavlenko AndreyPavlenko linked an issue Mar 15, 2025 that may be closed by this pull request
[TEST] Fix test_matmul.py failures #3307
Open
@AndreyPavlenko AndreyPavlenko removed a link to an issue Mar 15, 2025
[TEST] Fix test_matmul.py failures #3307
Open
@vlad-penkin vlad-penkin linked an issue Mar 17, 2025 that may be closed by this pull request
Several test cases from test_matmul.py::test_mxfp fail with "Mismatched elements error" #3677
Open
@AndreyPavlenko AndreyPavlenko force-pushed the enable_test_mxfp branch 2 times, most recently from 5aa92ee to 84f9971 Compare March 19, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitneywhtsang whitneywhtsang whitneywhtsang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several test cases from test_matmul.py::test_mxfp fail with "Mismatched elements error"
2 participants
@AndreyPavlenko @whitneywhtsang