Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sphinx to 8.0.2 and myst-parser to 4.0.0 #4369

Closed

Conversation

himanshulohote
Copy link

@himanshulohote himanshulohote commented Aug 20, 2024

Hey team,

I’ve updated the Sphinx and myst-parser dependencies to their latest versions:

  • Sphinx: Upgraded from 7.4.7 to 8.0.2
  • myst-parser: Updated from 3.0.1 to 4.0.0

Why the Change?
This update helps us stay current with the latest features and fixes for these tools. It’s all about keeping our documentation in tip-top shape!

What I Did:

  • Updated the doc/requirements.txt file with the new versions.
  • Rebuilt the docs to make sure everything works smoothly.

How to Check:

  • I built the documentation using sphinx-build -b html . _build/html.
  • Made sure all tables are formatted nicely.
  • Verified that all links in the Table of Contents work correctly.

Related Issue:
This PR addresses #4311 and will close the issue when merged.

Everything looks good to me, but please take a look and let me know if you see anything that needs tweaking. Thanks for reviewing!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened here, but it looks like maybe you checked in an env/ directory that shouldn't have been checked in? The PR is showing 5000+ file changes and is un-mergeable as is.

@mastersans
Copy link
Member

mastersans commented Aug 20, 2024

Hey you can mention env folder in .gitignore file if i am correct its your python environment(my tab just froze so its hard to tell based on contents of file) so that while git stagging changes it gets ignore.

@terriko
Copy link
Contributor

terriko commented Oct 29, 2024

It's been a few months, I think I'm going to assume the PR won't be fixed. Do feel free to re-open or open a new one if you're able to get it working!

@terriko terriko closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants