Skip to content

fix crash in frequency benchmark table rendering when mismatch in core counts #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

fix crash in frequency benchmark table rendering when mismatch in core counts #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions internal/report/table_defs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2077,6 +2077,14 @@ func frequencyBenchmarkTableValues(outputs map[string]script.ScriptOutput) []Fie
if len(scalarIaddFreqs) < len(specSSEFreqs) {
specSSEFreqs = specSSEFreqs[:len(scalarIaddFreqs)]
}
// pad the spec frequencies with the last value if they are shorter than the scalar_iadd frequencies
// this can happen when the first die has fewer cores than other dies
if len(specSSEFreqs) < len(scalarIaddFreqs) {
diff := len(scalarIaddFreqs) - len(specSSEFreqs)
for range diff {
specSSEFreqs = append(specSSEFreqs, specSSEFreqs[len(specSSEFreqs)-1])
}
}
}
// create the fields
fields := []Field{
Expand Down Expand Up @@ -2107,16 +2115,32 @@ func frequencyBenchmarkTableValues(outputs map[string]script.ScriptOutput) []Fie
for i := range scalarIaddFreqs { // scalarIaddFreqs is required
fields[coresIdx].Values = append(fields[coresIdx].Values, fmt.Sprintf("%d", i+1))
if specSSEFieldIdx > 0 {
fields[specSSEFieldIdx].Values = append(fields[specSSEFieldIdx].Values, specSSEFreqs[i])
if len(specSSEFreqs) > i {
fields[specSSEFieldIdx].Values = append(fields[specSSEFieldIdx].Values, specSSEFreqs[i])
} else {
fields[specSSEFieldIdx].Values = append(fields[specSSEFieldIdx].Values, "")
}
}
if scalarIaddFieldIdx > 0 {
fields[scalarIaddFieldIdx].Values = append(fields[scalarIaddFieldIdx].Values, fmt.Sprintf("%.1f", scalarIaddFreqs[i]))
if len(scalarIaddFreqs) > i {
fields[scalarIaddFieldIdx].Values = append(fields[scalarIaddFieldIdx].Values, fmt.Sprintf("%.1f", scalarIaddFreqs[i]))
} else {
fields[scalarIaddFieldIdx].Values = append(fields[scalarIaddFieldIdx].Values, "")
}
}
if avx2FieldIdx > 0 {
fields[avx2FieldIdx].Values = append(fields[avx2FieldIdx].Values, fmt.Sprintf("%.1f", avx256FmaFreqs[i]))
if len(avx256FmaFreqs) > i {
fields[avx2FieldIdx].Values = append(fields[avx2FieldIdx].Values, fmt.Sprintf("%.1f", avx256FmaFreqs[i]))
} else {
fields[avx2FieldIdx].Values = append(fields[avx2FieldIdx].Values, "")
}
}
if avx512FieldIdx > 0 {
fields[avx512FieldIdx].Values = append(fields[avx512FieldIdx].Values, fmt.Sprintf("%.1f", avx512FmaFreqs[i]))
if len(avx512FmaFreqs) > i {
fields[avx512FieldIdx].Values = append(fields[avx512FieldIdx].Values, fmt.Sprintf("%.1f", avx512FmaFreqs[i]))
} else {
fields[avx512FieldIdx].Values = append(fields[avx512FieldIdx].Values, "")
}
}
}
return fields
Expand Down