2nd round of added support for Clearwater Forest (CWF) architecture in report tables #314
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends support for Clearwater Forest (CWF) architecture in the report tables and metrics processing.
- Updates frequency calculation and clustering mode logic to include CWF support.
- Adjusts table definitions to conditionally incorporate CWF alongside other architectures.
- Extends metadata counter logic by adding a CWF case.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/report/table_helpers.go | Adds CWF support in frequency bucket calculations and clustering mode. |
| internal/report/table_defs.go | Incorporates CWF into table definitions and insight generation logic. |
| cmd/metrics/metadata.go | Updates GP counter logic to include CWF using a fallthrough case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.