Skip to content

fix: imported custom property type #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imaspen
Copy link

@imaspen imaspen commented Apr 25, 2025

Imported custom properties currently default the type to null. This causes the state to then update with the real type value, which triggers a forced replacement. This fetches the type from the organization property schema and adds it on import.

Resolves #2639


Before the change?

  • An imported custom property resource's property_type is set to null, which causes the configuration to trigger a forced replacement of the resource.

After the change?

  • The property type is fetched from the organisation schema and set correctly, preventing the resource replacement.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Imported custom properties currently default the type to null. This
causes the state to then update with the real type value, which triggers
a forced replacement. This fetches the type from the organization
property schema and adds it on import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: imported github_repository_custom_property type missing
1 participant