-
Notifications
You must be signed in to change notification settings - Fork 44
add operator-sdk version check to makefile #160
base: master
Are you sure you want to change the base?
Conversation
|
||
.PHONY: code/run | ||
code/run: | ||
@operator-sdk up local --namespace=${NAMESPACE} | ||
@$(OPERATOR_SDK) up local --namespace=${NAMESPACE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this recipe is broken, should be something along the lines of @$(OPERATOR_SDK) run --local --namespace=${NAMESPACE}
for <0.15.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that one comment (not that big of a deal since AMO is rarely run locally, so we can ignore it for now).
Other than that, the manifests/k8s generate without a problem
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HubertStefanski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pb82 @david-martin @grdryn , If you'd like to take a look and approve? |
@philbrookes: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.