Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom HTML on successful login page #308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bartlettc22
Copy link

Adding a CLI option for adding a custom HTML string for the successful login page. I saw you already had this option in the oauth2cli package so I brought in through to kubelogin.

Fixes #307

@codecov-commenter
Copy link

Codecov Report

Merging #308 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   72.37%   72.48%   +0.11%     
==========================================
  Files          20       20              
  Lines         713      716       +3     
==========================================
+ Hits          516      519       +3     
  Misses        130      130              
  Partials       67       67              
Impacted Files Coverage Δ
pkg/usecases/authentication/authentication.go 83.72% <ø> (ø)
pkg/adaptors/cmd/root.go 91.17% <100.00%> (+0.26%) ⬆️
pkg/usecases/authentication/authcode.go 64.00% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 822f6c8...5e8364e. Read the comment docs.

@sfxworks
Copy link

sfxworks commented Jul 6, 2020

How does one apply this?

- name: keycloak
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1beta1
      args:
      - oidc-login
      - get-token
      - --oidc-issuer-url=https://keycloak.sfxworks.net/auth/realms/mcsh
      - --oidc-client-id=account
      - --oidc-client-secret=my-secret
      - --server-success-html='<iframe src="https://my-iframe.example" title="Welcome"></iframe>'
      command: kubectl
      env: null

Yields

$ kubectl get pods
error: unknown flag: --server-success-html
exit status 1
error: unknown flag: --server-success-html
exit status 1

on build.

Yet the option is available in kubelogin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Custom page on successful login
4 participants