**fix: resolve duplicate SkipToContent component #72**#116
Open
Awointa wants to merge 2 commits into
Open
Conversation
|
@Awointa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Hi @Awointa Please record a video of your implementation, and what you did for review. Secondly, the CI did not pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the misplaced
SkipToContentorganism and consolidates all imports to the correct atoms version. A skip link is an indivisible UI primitive — it belongs incomponents/atoms/per Atomic Design principles. The duplicate was causing import confusion with no functional benefit.Changes
Deleted
components/organisms/skip-to-content.tsx— removed the violating duplicateUpdated
app/layout.tsx— import path updated to point tocomponents/atoms/skip-to-content.tsxVerified
SkipToContentcomponent retainsfocus-visiblestyles for keyboard accessibilityValidation
#main-contentpnpm buildpasses locallyScreen Recording
Checklist
main.mdfiles or AI tool folders committedpnpm buildpasses — confirmed locally before pushingCloses #72