Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle multiple confirms #24

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

axelo
Copy link
Contributor

@axelo axelo commented Sep 13, 2024

Part of https://github.com/insurello/insurello/issues/4732

This PR updates the event handlers that detects if a message has been published (confirmed) when more than one message has been confirmed at once by the broker.

Reference: https://www.rabbitmq.com/tutorials/tutorial-seven-dotnet#strategy-3-handling-publisher-confirms-asynchronously

multiple: this is a boolean value. If false, only one message is confirmed/nack-ed, if true, all messages with a lower or equal sequence number are confirmed/nack-ed.

@emilklasson
Copy link
Contributor

🌟

@axelo axelo merged commit 3a4a4d7 into master Sep 16, 2024
2 checks passed
@axelo axelo deleted the bug-fix-support-multiple-confirms branch September 16, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants