Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz report should use user's preference of CSV #2369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gao-Jun
Copy link
Contributor

@Gao-Jun Gao-Jun commented Jun 15, 2024

While generating quiz report, the generated CSV file doesn't use the user's preference of CSV. This patch fix this issue.

Test plan

  • Update user preference of CSV, use semicolon(;) as separator.
  • Create a new quiz, and have a submission. (quiz with no submission can not be exported)
  • Export 'Student Analysis' or 'Item Analysis' of this quiz.

Expected
The exported CSV file should use semicolon(;) as separator

Actual result
The exported CSV file still use comma(,) as separator

@instructure-sentry-integration

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/models/quizzes/quiz_statistics.rb

Function Unhandled Issue
generate_csv InstFS::ServiceError: received code "502" from service, with message " Quizzes::Quiz...
Event Count: 2
generate_csv InstFS::BadRequestError: received code "400" from service, with message ""The service received no request body and has tim... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@Gao-Jun
Copy link
Contributor Author

Gao-Jun commented Jun 15, 2024

How to view the detail of these 'Unhandled Issue'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants