Repository navigation
only inject preamble when the plugin is actually getting installed - #76
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change limiting Gemfile preamble injection to plugin installation.
No open issues 🎉
What changed in this PR
Limits Gemfile preamble injection to plugin installation, preventing ordinary Bundler commands from modifying alternate Gemfiles when loading the plugin from its index.
Changes:
- Detects plugin installation before injecting the preamble, retaining the existing loaded and frozen-bundle checks.
- Adds regression coverage for an alternate Gemfile using the main application's plugin index.
| File | Description |
|---|---|
spec/bundler/multilock/preamble_spec.rb |
Verifies that loading an indexed plugin leaves an alternate Gemfile unchanged. |
lib/bundler/multilock.rb |
Restricts preamble injection to plugin installation. |
Review effort: Balanced
jbutte
approved these changes
Oct 29, 2026
maths22
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.