Repository navigation
fix caching of relative path source gems - #75
Merged
Merged
Conversation
maths22
approved these changes
Oct 29, 2026
There was a problem hiding this comment.
🟡 Changes recommended
The path-source check also matches Git sources, causing alternate-lockfile caching with Git gems to raise when expanded_original_path expands their uninitialized @original_path.
1 open issue
What changed in this PR
This PR fixes caching of relative path gems declared in alternate Gemfiles, while keeping gems inside the project out of the cache.
Changes:
- Resolve relative source paths from the declaring Gemfile’s directory while preserving the project cache destination.
- Skip caching path gems located inside the project.
- Add regression specs for external and internal relative path gems.
| File | Description |
|---|---|
| spec/bundler/multilock_cache_spec.rb | Tests relative path caching with an alternate Gemfile in a subdirectory. |
| lib/bundler/multilock/ext/runtime.rb | Adjusts source path resolution, cache destinations, and internal path exclusions. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rmsy
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.