Enable miscellaneous ruff rules #471
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
booxter
commented
Apr 15, 2025
booxter
commented
- chore: Enable flake8-bugbear checks
- chore: Enable Pyflakes checks
- chore: Enable pyupgrade
- chore: Enable flake8-simplify
Signed-off-by: Ihar Hrachyshka <[email protected]>
Signed-off-by: Ihar Hrachyshka <[email protected]>
Signed-off-by: Ihar Hrachyshka <[email protected]>
Signed-off-by: Ihar Hrachyshka <[email protected]>
|
Why do we need this? |
|
Reasons:
|
booxter
commented
Apr 16, 2025
| @@ -732,7 +723,8 @@ class UniversalCheckpointArgs: | |||
| if UNIVERSAL_CHECKPOINT_INFO not in ds_checkpoint.global_state: | |||
| warnings.warn( | |||
| "Universal checkpoint information not found, setting it to " | |||
| "an empty dictionary." | |||
| "an empty dictionary.", | |||
| stacklevel=2, | |||
There was a problem hiding this comment.
these should probably be stacklevel=1 after all
booxter
commented
Apr 16, 2025
| "3. Disable flash attention by setting `disable_flash_attn=True` in your training arguments\n" | ||
| ) from exc | ||
| # also verify that the flash_attn package is actually installed | ||
| if check_flash_attn_enabled( |
There was a problem hiding this comment.
TODO: confirm this detection works as I expect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.