Skip to content

Simplify unused sample DB query #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matiasgarciaisaia merged 1 commit into from
Sep 5, 2025
Merged

Simplify unused sample DB query #2393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions lib/ask_web/controllers/survey_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,19 +66,12 @@ defmodule AskWeb.SurveyController do
Repo.all(
from s in Survey,
left_join: r in Respondent,
on: r.survey_id == s.id,
on: r.survey_id == s.id and r.disposition == :registered,
where: s.project_id == ^project.id and s.state == :terminated,
# we could mix a `count` with a `where` clause filtering for respondent disposition
# instead of doing the sum+if, but that wouldn't return surveys with 0 respondents available
select: %{survey_id: s.id, name: s.name, ended_at: s.ended_at, respondents: sum(fragment("if(?, ?, ?)", r.disposition == :registered, 1, 0))},
group_by: [s.id]
) |> Enum.map(fn s -> %{
survey_id: s.survey_id,
name: s.name,
ended_at: s.ended_at,
respondents: s.respondents |> Decimal.to_integer
} end)
|> Enum.sort_by(fn s -> - s.respondents end)
select: %{survey_id: s.id, name: s.name, ended_at: s.ended_at, respondents: count(r.id)},
group_by: [s.id],
order_by: [desc: count(r.id)]
)

render(conn, "unused_sample.json", surveys: surveys)
end
Expand Down