Skip to content

CSV generation feedback #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matiasgarciaisaia merged 3 commits into from
Aug 29, 2025
Merged

CSV generation feedback #2388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4385cc9
Instantly mark file as being generated on UI
matiasgarciaisaia Aug 4, 2025
4409d24
Animate icon upon file regeneration
matiasgarciaisaia Aug 4, 2025
cfa4b3a
Extract reducer logic to a function
matiasgarciaisaia Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions assets/css/_card-modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,22 @@
gap: 0.5rem;
}

.spinning {
animation: spin 1s linear infinite;
}

@keyframes spin {
0% {
transform: rotate(0deg);
}
60% {
transform: rotate(360deg);
}
100% {
transform: rotate(360deg);
}
}

a {
display: inline-flex;
cursor: pointer;
Expand Down
2 changes: 1 addition & 1 deletion assets/js/components/respondents/RespondentIndex.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ class RespondentIndex extends Component<Props, State> {
const createdAtLabel = fileExists ? <TimeAgo date={(fileStatus?.created_at || 0) * 1000} formatter={this.timeFormatter} /> : null

const fileCreating = !!fileStatus?.creating
const generateButtonClass = fileCreating ? "grey-text" : "black-text"
const generateButtonClass = fileCreating ? "grey-text spinning" : "black-text"
const generateButtonOnClick = fileCreating ? null : item.onGenerate
const generatingFileLabel = fileCreating ? "Generating..." : ""

Expand Down
15 changes: 15 additions & 0 deletions assets/js/reducers/respondentsFiles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,22 @@
import * as actions from "../actions/survey"

const markAsCreating = (files, creatingFile) => ({
...files,
[creatingFile]: {
...files[creatingFile],
file_type: creatingFile,
creating: true,
created_at: null,
}
})

export default (state = {}, action) => {
switch (action.type) {
case actions.GENERATING_FILE:
return {
...state,
files: markAsCreating(state.files || {}, action.file),
}
case actions.FETCHING_FILES_STATUS:
if (action.surveyId != state.surveyId) {
return {
Expand Down