You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate base image of the ebpf-profiler building image from debian:testing to registry.redhat.io/ubi8/ubi-minimal:latest
Attention: Clang version on this image is 18, not 16.
Refactor the files to build the ebpf-profiler building image to the directory docker-image
The docker image entrypoint moves to /agent/go/bin all the binaries needed by GO for the generation and linting
Makefile: pin GO deps versions
Attention: pin porto version to "v0.6.0" (instead of latest). The latest version of porto requires GO 1.23.
Makefile: fix the clean target.
Makefiles: substitute clang-16 with clang.
Makefile: remove the installation of GolangCi deps during linting.
Migrate the build on redhat ubi-minimal 8.
Attention: Clang version on this image is 18, not 16.
Isolate docker files in directory docker-image.
Introduce an entrypoint for the docker image, to better deal with the GO
environment.
Dockerfile: install GolangCi deps in the docker image, copy the binaries
in the container's workdir in /agent/go/bin.
Makefile: fix the clean target.
Makefiles: substitute clang-16 with clang.
Makefile: remove the installation of GolangCi deps during linting.
Makefile: add targets for GO deps management
Makefile: pin GO deps versions
Makefile: pin porto version to "v0.6.0" (instead of latest).
The latest version of porto requires GO 1.23.
Makefile: improve target linter-version, print all GolangCi deps
versions.
GO: touch go/bin/.gitkeep, the directory bin contains the GO deps
According to the PR, clang-18 would break some tests on kernels 4.19.314 and 5.4.276. They are considering to use clang-17.
However, our baseline Amazon Linux 2 kernel is 5.10 version, so ideally we should be good there? WDYTH @teresanovielloatinstana
According to the PR, clang-18 would break some tests on kernels 4.19.314 and 5.4.276. They are considering to use clang-17. However, our baseline Amazon Linux 2 kernel is 5.10 version, so ideally we should be good there? WDYTH @teresanovielloatinstana
We decided during a team meeting to follow the community and do a first integration step using clang-17. I will close this PR and work in another branch.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
teresanovielloatinstana
force-pushed
the
migrate_to_redhat-ubi-minimal-8
branch
2 times, most recently
from
Reference
Jira ticket
WHAT
Migrate base image of the ebpf-profiler building image from
debian:testingtoregistry.redhat.io/ubi8/ubi-minimal:latestAttention: Clang version on this image is 18, not 16.
Refactor the files to build the ebpf-profiler building image to the directory
docker-imageThe docker image entrypoint moves to /agent/go/bin all the binaries needed by GO for the generation and linting
Makefile: pin GO deps versions
Attention: pin porto version to "v0.6.0" (instead of latest). The latest version of porto requires GO 1.23.
Makefile: fix the clean target.
Makefiles: substitute clang-16 with clang.
Makefile: remove the installation of GolangCi deps during linting.
Makefile: add targets for GO deps management
WHY
2-7: Fixes