Skip to content

Conversation

AlexMokrushin
Copy link

What did you change and why?

Added isStarted property to TrueTimeClient and NTPClient.
If start() is called occasionally twice, app crashes on check :

precondition(self.reachability.callback == nil, "Already started")

We can avoid this crash calling start() like that:

let client = TrueTimeClient.sharedInstance
if (!client.isStarted) {
    client.start(pool: [NTP_HOST], port: NTP_PORT)
}

Potential risks introduced?

No new risks.

What tests were performed (include steps)?

Manual tests.

Checklist

  • Unit/UI tests have been written (if necessary)
  • Manually tested

This allows to avoid crash on check: precondition(self.reachability.callback == nil, "Already started")
@danielerneBIT
Copy link

Any updates about this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants