Update src/messenger/webim/js/source/common.js#18
Open
Ha99y wants to merge 1 commit intoinspirer:v1.6.xfrom
Ha99y:patch-1
Open
Update src/messenger/webim/js/source/common.js#18Ha99y wants to merge 1 commit intoinspirer:v1.6.xfrom Ha99y:patch-1
Ha99y wants to merge 1 commit intoinspirer:v1.6.xfrom
Ha99y:patch-1
Conversation
Update playSound function to use audio tag for sound and the function does not have to create new div element anymore. Just calls the play function when ever playing sound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update playSound function to use audio tag for sound and the function does not have to create new div element anymore. Just calls the play function when ever playing sound.