Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Go to the docs" link. #32

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix "Go to the docs" link. #32

merged 1 commit into from
Feb 2, 2024

Conversation

eiffel-fl
Copy link
Member

No description provided.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-mushroom-00d947803-32.westeurope.1.azurestaticapps.net

@eiffel-fl eiffel-fl force-pushed the francis/fix-go-to-the-docs branch from 044304b to e5afedd Compare January 25, 2024 06:33
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-mushroom-00d947803-32.westeurope.1.azurestaticapps.net

@@ -39,6 +39,6 @@ features:
feature_matrix:
data: gadgets
title: The Gadgets
learn_more_link: https://www.inspektor-gadget.io/docs/latest/gadgets/
learn_more_link: https://www.inspektor-gadget.io/docs/latest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not that sure, because it means we will need to change this link when we will remove the built-in gadgets and we will without any doubts forget to do so.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we remove the built-in gadgets we'll have to change a lot of the website. I'll approve it anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!

Signed-off-by: Francis Laniel <[email protected]>
@eiffel-fl eiffel-fl force-pushed the francis/fix-go-to-the-docs branch from e5afedd to 179f7f6 Compare February 2, 2024 03:15
Copy link

github-actions bot commented Feb 2, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-mushroom-00d947803-32.westeurope.1.azurestaticapps.net

@eiffel-fl
Copy link
Member Author

Thank you for the review!

@eiffel-fl eiffel-fl merged commit c2a87b3 into main Feb 2, 2024
2 checks passed
@eiffel-fl eiffel-fl deleted the francis/fix-go-to-the-docs branch February 2, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants