trigger test from yurovska/tern/tree/821_ancova_weights

[shajoezhu]

No description provided.

[github-actions]

Unit Tests Summary

  1 files  112 suites   3m 32s ⏱️
249 tests 249 ✅ 0 💤 0 ❌
530 runs  530 ✅ 0 💤 0 ❌

Results for commit 85b053c.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
char-support	👶		$+2.92$	$+6$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
char-support	👶		$+1.17$	CRITDIR_is_factor_and_one_PARAMCD_is_not_available_on_all_AVISITS
char-support	👶		$+0.90$	CRITDIR_is_not_factor_and_all_PARAMCD_available_on_all_AVISITS
char-support	👶		$+0.85$	CRITDIR_is_not_factor_and_one_PARAMCD_is_not_available_on_all_AVISITS
table_aovt01	👶		$+0.74$	AOVT01_variant_with_proportional_weights_is_produced_correctly

Results for commit 585b351

♻️ This comment has been updated with latest results.

[yurovska]

@shajoezhu Since I have no permission to commit in this branch, could you please add the following test in tests/testthat/test-table_aovt01.R:

testthat::test_that("AOVT01 variant with proportional weights is produced correctly", {
  adqs_multi <- dplyr::filter(adqs, AVISIT == "WEEK 1 DAY 8")
  n_per_arm <- table(adsl$ARM)

  result <- basic_table() %>%
    split_cols_by("ARMCD", ref_group = "ARM A", split_fun = ref_group_position("first")) %>%
    add_colcounts() %>%
    split_rows_by("PARAMCD") %>%
    summarize_ancova(
      vars = "CHG",
      variables = list(arm = "ARMCD", covariates = c("BASE", "STRATA1")),
      conf_level = 0.95, var_labels = "Adjusted mean",
      weights_emmeans = "proportional"
    ) %>%
    build_table(adqs_multi, alt_counts_df = adsl)

  res <- testthat::expect_silent(result)
  testthat::expect_snapshot(res)
})

[shajoezhu]

thanks guys! @Melkiades @yurovska

[Copilot]

Copilot reviewed 2 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (8)

• .lintr: Language not supported
• DESCRIPTION: Language not supported
• tests/testthat/test-char-support.R: Language not supported
• tests/testthat/test-listing_adal02.R: Language not supported
• tests/testthat/test-table_aet04.R: Language not supported
• tests/testthat/test-table_aovt01.R: Language not supported
• tests/testthat/test-table_pkpt04.R: Language not supported
• tests/testthat/test-table_pkpt05.R: Language not supported

Comments suppressed due to low confidence (2)

tests/testthat/_snaps/table_aovt01.md:73

• The horizontal divider uses non-standard dash characters; consider using standard hyphen characters for clarity and consistency.

      ——————————————————————————————————————————————————————————————————————————

tests/testthat/_snaps/char-support.md:17

• [nitpick] Ensure consistent naming for heart rate labels; consider using 'HR' consistently across all instances instead of mixing 'HR' and 'Heart Rate'.

                  HIGH Heart Rate       5 (3.7%)      3 (2.2%)        8 (6.1%)

[Melkiades]

Lgtm! Thanks for adding also the breaking change snapshot @shajoezhu. Could you only check this?

tests/testthat/_snaps/table_aovt01.md:73

The horizontal divider uses non-standard dash characters; consider using standard hyphen characters for clarity and consistency.

[Melkiades]

Actually good to go. I know we replace the hyphen with the generic "-" in the CRAN packages but here it is not necessary!