Skip to content

Removed not needed SRP #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 17, 2025
Merged

Removed not needed SRP #73

merged 7 commits into from
Jun 17, 2025

Conversation

coot
Copy link
Collaborator

@coot coot commented May 21, 2025

No description provided.

@coot coot force-pushed the coot/srp branch 2 times, most recently from 3aed0e1 to bdca754 Compare May 22, 2025 09:08
@coot coot requested a review from Copilot June 17, 2025 09:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Centralize GHC settings in a common GHC stanza, remove redundant per-stanza flags, update maintainers and descriptions, prune unused dependencies, and bump the Hackage index state.

  • Added a common GHC section for default-language, extensions, and ghc-options, then imported it in each library and the test-suite.
  • Stripped duplicate default-language, default-extensions, and ghc-options from individual stanzas.
  • Removed certain build-depends entries (si-timers, time, singletons) and updated the index-state in cabal.project, dropping the source-repository-package block.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
typed-protocols/typed-protocols.cabal Introduced common GHC stanza, imported it everywhere, and cleaned up individual stanza settings
typed-protocols/test/Network/TypedProtocol/ReqResp/Tests.hs Dropped Control.Monad.Class.MonadTimer.SI import and removed the MonadDelay constraint
cabal.project Bumped index-state and removed the source-repository-package block
Comments suppressed due to low confidence (3)

typed-protocols/typed-protocols.cabal:154

  • The test-suite no longer depends on si-timers. If any tests rely on timer utilities from io-classes, they will fail to compile. Please verify that all timing functionality has been removed or re-add si-timers if needed.
, io-classes:io-classes

typed-protocols/typed-protocols.cabal:137

  • The examples library no longer lists time as a dependency but it was previously included. If example modules use any time functions, this dependency must be restored or the code updated to remove those uses.
build-depends:    network

typed-protocols/typed-protocols.cabal:23

  • [nitpick] Consider adding other widely-used extensions (e.g. DataKinds, GADTs) or shared fields into the common GHC stanza if most libraries require them, to further reduce duplication.
common GHC

Show instance which shows parens if needed.
@coot coot added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit 3b65eae Jun 17, 2025
13 checks passed
@coot coot deleted the coot/srp branch June 17, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants