Skip to content

Use sublibraries #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 21, 2025
Merged

Use sublibraries #66

merged 11 commits into from
May 21, 2025

Conversation

coot
Copy link
Collaborator

@coot coot commented Sep 29, 2024

Use sublibraries. This can be merged once cardano switches to GHC >= 9.4.
Once this PR is merged, typed-protocols can be published to Hackage 🎉.

  • typed-protocols: use sublibraries
  • GHA: haddocks

Warning

We need to switch to ghc >= 9.6 in cardano-node before this PR can be merged & published (because of haskell.nix support of sublibraries & cross-compilation).

@coot coot force-pushed the coot/sublibraries branch from 16fbb92 to 69cb93f Compare December 12, 2024 11:32
@coot coot marked this pull request as ready for review December 12, 2024 11:32
@coot coot force-pushed the coot/sublibraries branch from c84f6ed to 88326a7 Compare March 5, 2025 11:09
@coot coot force-pushed the coot/sublibraries branch 2 times, most recently from fcaddb9 to 0750f27 Compare May 14, 2025 14:42
@coot coot requested a review from crocodile-dentist May 14, 2025 14:45
@coot coot force-pushed the coot/sublibraries branch from f3c31b9 to 44660a1 Compare May 15, 2025 11:03
Copy link

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coot coot force-pushed the coot/sublibraries branch 4 times, most recently from fb6dc87 to 12c98e5 Compare May 16, 2025 11:29
@coot
Copy link
Collaborator Author

coot commented May 16, 2025

I pulled two other commits from #62.

@coot coot force-pushed the coot/sublibraries branch from 72c6bb0 to cf67d29 Compare May 21, 2025 13:03
The goal was to use GHC2024, but that's only supported by `GHC >= 9.10`.
Required extensions which are part of GHC2024 are added to
`default-extensions`.
@coot coot force-pushed the coot/sublibraries branch from cf67d29 to 852fc10 Compare May 21, 2025 13:06
@coot coot force-pushed the coot/sublibraries branch from 852fc10 to cd1e9d6 Compare May 21, 2025 13:45
@coot coot added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 88e3f84 May 21, 2025
13 checks passed
@coot coot deleted the coot/sublibraries branch May 21, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants