Skip to content

Conversation

@damrobi
Copy link
Collaborator

@damrobi damrobi commented Nov 3, 2025

Content

This PR includes a new module for mithril-stm containing an implementation for the Schnorr signature that will be used in the SNARK version of mithril.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #2756

@damrobi damrobi added the feature 🚀 New implemented feature label Nov 3, 2025
@damrobi damrobi force-pushed the damrobi/stm-add-schnorr-sig-module branch from b254ad2 to 1e07c07 Compare November 5, 2025 08:22
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo-doc found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Test Results

    4 files  ±0    168 suites  ±0   22m 40s ⏱️ -16s
2 207 tests ±0  2 207 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 887 runs  ±0  6 887 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 439344a. ± Comparison against base commit 2ad7d5e.

♻️ This comment has been updated with latest results.

@damrobi damrobi changed the title Added file structure for Schnorr signature module. Implementation of Schnorr signature module for mithril-stm. Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature 🚀 New implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants