-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-8235 Improve traces for chain-seek and chain-query #735
Conversation
4e1026f
to
dcdd241
Compare
|
635c525
to
1ee83d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
- Use `PeerT` instead of `PeerTraced` - Add trace spans and span context propagation - Update usages
- Add a peerT implementation - Add span context info to message types - Add default trace spans to clients and servers.
1ee83d6
to
2c1b584
Compare
This PR is part of a larger effort to overhaul the tracing of the protocol peers.
PeerT
indexed monad transformer.PeerT
implementation forChainSeekClient
andChainSeekServer
PeerT
implementation forQueryClient
andQuery
SpanContext
propagation to the message types of these two protocols.chain-seek
andchain-sync-query
within the runtime to use thePeerT
implementation instead of thePeerTraced
implementationPre-submit checklist: